Pull Request: CInterface Update

This forum is for tracking and working on active issues that need to be resolved, as well as testing Pull Requests that are waiting to be integrated into Torque 3D.
1 post Page 1 of 1
LukasPJ
Site Admin
Posts: 388
Joined: Tue Feb 03, 2015 7:25 pm
 
by LukasPJ » Wed Jan 17, 2018 10:08 am
Pull request: https://github.com/GarageGames/Torque3D/pull/2136
Branch: https://github.com/lukaspj/Torque3D/tre ... ace-update

The PR seeks to update the CInterface, which was left in order to integrate JavaScript with T3D.

My main issues with the existing solution was that it still used the TorqueScript console for method calls, which is inefficient compared to calling functions directly. Also it didn't really work any more.
Furthermore, this CInterface seeks to transfer the control of method-lookups and the like from the console to the script that interfaces with the engine.

Main issues that needs to be addressed:

Script->Cinterface calls
In the codeInterpreter.cpp, TorqueScript calls the CInterface, this code should be reviewed / verified:
https://github.com/GarageGames/Torque3D ... b21c6f783b

In console.cpp, the CInterface is called before the console is inquired about evaluation of the function call. This should be reviewed / verified:
https://github.com/GarageGames/Torque3D ... 067262f6ad


Cinterface->Engine calls
In engineTypes.h, the ValueType of EngineStructTypeTraits has been changed, despite the fact there was a clear reason that it had the original type to begin with. This should be reviewed / verified:
https://github.com/GarageGames/Torque3D ... 9c865a5cc6
1 post Page 1 of 1

Who is online

Users browsing this forum: No registered users and 0 guests