Page 2 of 3

Re: Pre-Pull Request: Deferred Shading

Posted: Tue Jan 19, 2016 6:32 pm
by razvanab
@razvanab
Az means that in the Deferred_Complete_3.8 branch that we'll be testing to make sure the Deferred stuff is ready, he's merged in those OpenGL fixes that Lopuska made.

Once this branch has been sufficiently tested though, yes, it will be PR'd and rolled into the main repository. So, if you'd like to see that happen sooner, feel free to grab it and do some testing :)
I already did that and so far it looks good. But I noticed some bugs on the water planes when I enable some post_fx for example bloom.
Are there some deferred specific bugs that I should be looking for?

Re: Pre-Pull Request: Deferred Shading

Posted: Tue Jan 19, 2016 9:18 pm
by Azaezel
Won't deferred shading make the engine much slower?
Prepass Lighting (advanced) is a deferred variant. Only major difference is we don't throw buffers out between prepass then multiply on diffuse.
But I noticed some bugs on the water planes when I enable some post_fx for example bloom.
Are there some deferred specific bugs that I should be looking for?
Image

Re: Pre-Pull Request: Deferred Shading

Posted: Tue Jan 19, 2016 10:43 pm
by Timmy
Won't deferred shading make the engine much slower?
Depending on your scene and hardware configuration, deferred shading can be faster than Prepass Lighting. While it certainly uses more bandwidth it also avoids rendering everything twice.

Re: Pre-Pull Request: Deferred Shading

Posted: Tue Jan 19, 2016 10:43 pm
by Azaezel
Looks like stock, bloom was never getting applied in the first place: http://imgur.com/a/gsIOg this one'll likely be a bit tricky.

Re: Pre-Pull Request: Deferred Shading

Posted: Tue Jan 19, 2016 11:11 pm
by razvanab
@
User avatar
Azaezel

That crack me up.

Re: Pre-Pull Request: Deferred Shading

Posted: Tue Jan 19, 2016 11:16 pm
by Azaezel
http://imgur.com/a/krd8g that work for folks?

Re: Pre-Pull Request: Deferred Shading

Posted: Wed Jan 20, 2016 12:10 am
by razvanab
http://imgur.com/a/krd8g that work for folks?
It looks good to me.

Re: Pre-Pull Request: Deferred Shading

Posted: Wed Jan 20, 2016 12:22 am
by Azaezel

Re: Pre-Pull Request: Deferred Shading

Posted: Mon Jan 25, 2016 9:09 pm
by JeffR
Did some testing on that here. Does indeed add the bloom back in, but it looks like the bloom is on even at night time in the Outpost level. Probably an artifact of how specularity is calculated on the water than anything else though.

Otherwise, seems like a solid fix. Anyone else noting any other problems? Because if not, this'll probably get rolled in in the next couple days if no one elses spots any issues.

Re: Pre-Pull Request: Deferred Shading

Posted: Wed Jan 27, 2016 8:52 pm
by newaged
What changes do you need to make to custom materials / shaders that worked in 3.8 to get them to work here? They are always replaced with a white mat in the deferred branch. Can't share the shader code, I didn't write it.