Clean-up of the issues and PR's on the repo

Friendly conversations, and everything that doesn't fit into the other forums.
9 posts Page 1 of 1
LukasPJ
Site Admin
Posts: 444
Joined: Tue Feb 03, 2015 7:25 pm
 
by LukasPJ » Wed May 27, 2020 11:03 pm
Hi!

So, @ Happenstance made this post describing the staleness of the current repository over at https://github.com/garagegames/torque3d

I asked around and got some background, @ JeffR has write-access but GG still owns that repository. As a result, @ JeffR can't give other people write-access, which means he's the only one that can merge PR's, close issues, assign labels etc. basically we can do nothing.

Therefore we need to migrate to a new repository, an organization has been made for this purpose: https://github.com/Torque3D but we need to migrate any PR's and issues that are still relevant and close any issues that are no longer relevant.

@ JeffR doesn't have time for this, so it falls on the community to lift this task if we want any progress on this. In the previously mentioned thread, it seems that there is a general request for having more people included in the general work is being done, so here is your chance to contribute back to the community!

I have created a Google Sheets document here:
https://docs.google.com/spreadsheets/d/ ... kycYjxk3CY

Please review as many issues as you can and report which should be migrated in the Google Sheets.
Happenstance
Posts: 104
Joined: Sat Apr 11, 2015 9:08 pm
by Happenstance » Fri May 29, 2020 2:30 am
Solid work, Lukas.

Am I misreading the spreadsheet or have you and Az already reviewed all 307 open issues?
LukasPJ
Site Admin
Posts: 444
Joined: Tue Feb 03, 2015 7:25 pm
 
by LukasPJ » Fri May 29, 2020 7:14 am
Solid work, Lukas.

Am I misreading the spreadsheet or have you and Az already reviewed all 307 open issues?
You did not misread, it took a while though 😄

Next step is figuring out how to migrate the issues!
Duion
Posts: 1622
Joined: Sun Feb 08, 2015 1:51 am
 
by Duion » Fri May 29, 2020 10:27 am
Finally someone doing something.
Regarding the migration, I would just manually copy and past it over, it seems like a lot of monotonous work, but when you spend too much time figuring out how to do it better, your way to do it better takes more effort.
Now would be the ideal time, to reset the repo, since Git saves everything in the history, the repo gets bigger and bigger, now as you make a lot of changes it will get even bigger and so on.
You could remove the art files from the repo, pack them somewhere else, so that the engine repo is code only and not big binary assets. The Soldier alone is 75MB and the art shapes folder 180MB, you could just throw that out. Sure you need some graphic files for GUI and default textures for all the things, but they are not the problem.
The problem now is how to replace the assets, since we would need a dummy like the blue guy, b ut if you have not art ready, I would suggest to just put a box in as placeholder for a player character.
Now is the time to re-design things, since you are throwing everything over board now anyways regarding design decissions, why not clean up the art assets as well, or at least put them in a different repo.
It is not that essential, but I like to have things nice, clean and efficcient.

By the way, is there a test version, like a pre-compiled binary with pre-installed template, that you can just copy and launch to test? Usually I use my existing project, update it and test it, but I use the old template, which does not exist anymore and now I have no idea how to do that.
Duion
Posts: 1622
Joined: Sun Feb 08, 2015 1:51 am
 
by Duion » Fri May 29, 2020 3:09 pm
Alternatively one could try and gain control over the Garagegames repository, since it has all the stars and followers or whatever, but I do not know how relevant that on Github is, but on social media this is very relevant. Even if the account creator does not exist anymore or can be traced down, it may still be recovered as I did with the Moddb account, where the official creator has long disappeared.
Question is, if it would make sense to do so, however I would still prefer resetting the repo in a cleaned up version on a new account and leave the original Garagegames repo for reference for older issues and code change history.
Azaezel
DEVGRU
Posts: 496
Joined: Tue Feb 03, 2015 9:50 pm
 
by Azaezel » Fri May 29, 2020 6:14 pm
https://github.com/Areloch/Torque3D/ working branch at time of writing. (may end up moving that to a fork on https://github.com/Torque3D/Torque3D, and from a quick look, already did so as of a couple days back). That'd be where most of those 'resolved' tags came from.

according to the discord pinned list (again, https://discord.gg/zSeWPfu is where we do the live chat and file toss around),
http://ghc-games.com/SC/Preview4_0_bld5_win.zip
http://ghc-games.com/SC/Preview4_0_bld5_lin.zip
http://ghc-games.com/SC/Preview4_0_bld5_mac.zip
for prebuilt binaries.

The general consensus seems to be not to use the garage games repo so folks stop getting the impression they should bug garage games themselves for fixes since they aren't doing the maintenance or upgrades.
Steve_Yorkshire
Posts: 342
Joined: Tue Feb 03, 2015 10:30 pm
 
by Steve_Yorkshire » Fri May 29, 2020 9:13 pm
*Changes bookmark to read @ JeffR master builds, because I can never remember his github username*
... squints at Az for same reason ... :evil:
LukasPJ
Site Admin
Posts: 444
Joined: Tue Feb 03, 2015 7:25 pm
 
by LukasPJ » Sat May 30, 2020 11:24 pm
Status Update

All the marked issues have been migrated:
https://github.com/Torque3D/Torque3D/issues

In case anyone is interested, I used the following piece of Go to migrate:

https://gist.github.com/lukaspj/4f3fed8 ... a9605b1fa3


So the next steps are:
Duion
Posts: 1622
Joined: Sun Feb 08, 2015 1:51 am
 
by Duion » Tue Jun 02, 2020 5:58 pm
@
User avatar
Azaezel

Windows prebuild binary fails for me with error "d3dcompiler47.dll is missing"

Edit: I fixed it, but I wonder why this happened, since I never had such issues with any games before.
9 posts Page 1 of 1

Who is online

Users browsing this forum: Bing [Bot] and 3 guests