Community Involvement: PR Reviews

Friendly conversations, and everything that doesn't fit into the other forums.
1 post Page 1 of 1
Bloodknight
Posts: 226
Joined: Tue Feb 03, 2015 8:58 pm
by Bloodknight » Sun Feb 03, 2019 6:10 pm
ok ok, more clickbait!

Once a week or two weeks depending on how often PRs are made I will be posting a short list of PRs that need to be reviewed or tested. Now that Travis has finally been implemented more effectively it should be far easier to determine whether the PRs at least compile on the *nix platforms, meaning the testing and reviewing should only need to be done.

Here are a couple of quick and easy ways to get hold of a single PR so that it can be built and tested, thanks to Timmy this has been reduced to just a few seconds of work.

How To

Method 1
find a PR you want to test, i'll use the sqlite one as an example.

Code: Select all

https://github.com/GarageGames/Torque3D/pull/2299
if you add .patch to the end of the PR you get

Code: Select all

https://github.com/GarageGames/Torque3D/pull/2299.patch
you see a whole .patch text file in the browser window, save the page/file
Image
i save mine to the root folder of my forked and cloned repo

assuming your branch is called development and it is on parity with the garagegames development branch, enter the following commands in gitbash or terminal launched from sourcetree. (i have a branch called gg-development specifically)

Code: Select all

git checkout development git branch TestPRs git checkout TestPRs git am 2299.patch
you should get somethimg like this.
Image

I don't yet know about the whitespace issues, but it doesn't affect the testing, or at least not the ones I've done so far. I will adapt the instructions when i get more details


Method 2
you can clone a new repository directly to your computer just for testing.

once you have the clone you can issue the following commands

Code: Select all

git fetch origin pull/2299/head:TestPRs git checkout TestPRs

cleaning up ready for the next PR
Once you have reviewed and/or tested the PR, you can delete the branch using

Code: Select all

git branch -d TestPRs
when this is done you are ready to start on the next PR.

-----------------------------------------------------------------------------------------------------

This is quite a valuable service for torque, it means that JeffR doesn't need to do all the testing himself, even tho many of the PRs are by seasoned devs like Azaezel and Timmy they still need to be reviewed. This means bugs get fixed quicker, features get added faster; It also means Jeff Az and Timmy can focus their time where we the community and users need them most, working on the stuff we don't understand, but make the engine shiny shiny.
1 post Page 1 of 1

Who is online

Users browsing this forum: No registered users and 4 guests